brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #645: Persist OSGi bundles
Date Thu, 27 Apr 2017 11:39:16 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/645#discussion_r113493218
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/BrooklynMementoRawData.java
---
    @@ -188,14 +211,22 @@ public String getBrooklynVersion() {
             return Collections.unmodifiableMap(catalogItems);
         }
         
    +    public Map<String, String> getBundles() {
    +        return Collections.unmodifiableMap(bundles);
    +    }
    +    
    +    public Map<String, ByteSource> getBundleJars() {
    +        return Collections.unmodifiableMap(bundleJars);
    +    }
    +    
         // to handle reset catalog
         @Beta
         public void clearCatalogItems() {
             catalogItems.clear();
         }
         
         public boolean isEmpty() {
    -        return planeId == null && entities.isEmpty() && locations.isEmpty()
&& policies.isEmpty() && enrichers.isEmpty() && feeds.isEmpty() &&
catalogItems.isEmpty();
    +        return planeId == null && entities.isEmpty() && locations.isEmpty()
&& policies.isEmpty() && enrichers.isEmpty() && feeds.isEmpty() &&
catalogItems.isEmpty() && bundles.isEmpty();
    --- End diff --
    
    `&& bundleJars.isEmpty()`, just for belt-and-braces security? (I know it would
be wrong to have one of `bundles` and `bundleJars` and not the other, but even so.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message