brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #645: Persist OSGi bundles
Date Thu, 27 Apr 2017 11:39:16 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/645#discussion_r113671948
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/persist/ListeningObjectStore.java
---
    @@ -209,6 +213,20 @@ public void put(String val) {
                 delegate.put(val);
             }
             @Override
    +        public void put(ByteSource val) {
    +            if (writesFailSilently)
    +                return;
    +
    +            for (ObjectStoreTransactionListener listener: listeners) {
    +                try {
    +                    listener.recordDataOut("writing (binary) "+path, Streams.readFullyAndClose(val.openStream()).length);
    --- End diff --
    
    Is it really worth the extra read and close just to be able to write the length here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message