brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #645: Persist OSGi bundles
Date Thu, 27 Apr 2017 11:39:16 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/645#discussion_r113664611
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindContextImpl.java
---
    @@ -85,6 +88,14 @@ public void registerFeed(String id, Feed feed) {
         public void registerCatalogItem(String id, CatalogItem<?, ?> catalogItem) {
             catalogItems.put(id, catalogItem);
         }
    +
    +    public void registerBundle(String id, ManagedBundle bundle) {
    --- End diff --
    
    As far as I (and Intellij IDEA) can see this is never called.  Should it be in `RebindIteration.installBundlesAndRebuildCatalog`
alongside the `rebindContext.installBundle`?   Similarly where does `unregister` get called?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message