brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #645: Persist OSGi bundles
Date Mon, 24 Apr 2017 16:00:04 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/645
  
    have done some extra manual testing, including running multiple servers, doing a `br catalog
add` (using the luvely https://github.com/apache/brooklyn-client/pull/44 ), and checking that
bundles are transferred across nicely.  all good.
    
    as noted in the PR above, one thing i find is that an attempt to re-upload a bundle is
silently.  it looks as though it is working but internally the first things `OsgiManager.installUploadedBundle()`
does is find a cache hit and ignores the input.  this is fine, good even, if a user is uploading
an identical bundle.  however we don't actually check whether the bundle is identical, and
if the bundle is changed:
    
    * it should fail if the version is not snapshot
    * it should install the new bundle and work towards abandoning the old bundle
    
    it's actually not easy to check whether the bundle is changed so i'm thinking we'll apply
the above logic whether or not the bundle has changed.
    
    by "work towards abandoning the old bundle" i mean:
    
    * remove it from persistence
    * deregister the old bundle in osgi ... java classes loaded from it may force the bundle
to be loaded but inaccessible until a rebind or explicit "upgrade to same version" (when available)
    * remove any catalog items from the previous bundle not present in the new bundle
    
    however i think this can all be done in another PR (and probably it will want a record
of the originating bundle, at least on the catalog item / registered type, so it will be a
bigger PR).
    
    (this PR doesn't support uninstall yet, but we can live with that for a wee while i think.)
    
    --
    
    we should also _not_ persist the catalog items for things coming from persisted bundles,
and when a bom is uploaded we should make it in to a bundle, so net net we stop creating catalog
items altogether.
    
    --
    
    can i get a review?  cc @geomacy @neykov @aledsage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message