brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Date Fri, 21 Apr 2017 13:59:21 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r112693227
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -51,21 +54,23 @@
      * <p>
      * In addition to the contract defined by the code,
      * subclasses should provide a public static <code>create(Class)</code>
    - * method to create an instance of the spec for the target type indicated by the argument.

    + * method to create an instance of the spec for the target type indicated by the argument.
      * <p>
      * The spec is then passed to type-specific methods,
      * e.g. {@link EntityManager#createEntity(org.apache.brooklyn.api.entity.EntitySpec)}
      * to create a managed instance of the target type.
      */
    -public abstract class AbstractBrooklynObjectSpec<T,SpecT extends AbstractBrooklynObjectSpec<T,SpecT>>
implements Serializable {
    +public abstract class AbstractBrooklynObjectSpec<T, SpecT extends AbstractBrooklynObjectSpec<T,
SpecT>> implements Serializable {
     
         private static final long serialVersionUID = 3010955277740333030L;
     
         private static final Logger log = LoggerFactory.getLogger(AbstractBrooklynObjectSpec.class);
    -    
    +
         private final Class<? extends T> type;
         private String displayName;
         private String catalogItemId;
    +    private Deque<String> catalogItemIdSearchPath = new ArrayDeque<>();
    --- End diff --
    
    minor - would be nice to avoid duplicates


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message