brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnmccabe <...@git.apache.org>
Subject [GitHub] brooklyn-client pull request #44: Added the ability to upload a zip via the ...
Date Tue, 18 Apr 2017 14:06:41 GMT
Github user johnmccabe commented on a diff in the pull request:

    https://github.com/apache/brooklyn-client/pull/44#discussion_r111962100
  
    --- Diff: cli/api/catalog/catalog.go ---
    @@ -23,6 +23,14 @@ import (
     	"fmt"
     	"github.com/apache/brooklyn-client/cli/models"
     	"github.com/apache/brooklyn-client/cli/net"
    +	"net/url"
    +        "path/filepath"
    --- End diff --
    
    indentation, worth adding `golint` and `go vet` to the build process to pick up stuff
like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message