brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <>
Subject [GitHub] brooklyn-server pull request #617: Persist management plane ID
Date Tue, 18 Apr 2017 09:30:33 GMT
Github user geomacy commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/
    @@ -224,6 +224,7 @@ public String getManagementPlaneId() {
         public void setManagementPlaneId(String newPlaneId) {
             if (managementPlaneId != null && !managementPlaneId.equals(newPlaneId))
                 log.warn("Management plane ID changed from {} to {}", managementPlaneId,
    +            log.debug("Management plane ID changed from {} to {}", new Object[] {managementPlaneId,
newPlaneId}, new RuntimeException("Stack trace for setManagementPlaneId"));
    --- End diff --
    I think this actually gives you `debug(String, Object, Object)` rather than an overload
that knows about `Throwable`, so you'll not get the right parameter matching here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message