brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #636: Enable older Java versions
Date Fri, 14 Apr 2017 12:29:50 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/636#discussion_r111567802
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java ---
    @@ -621,6 +621,7 @@ private static Object getFlag(Map<?,?> flags, String flagName,
Object defaultVal
         public static String installJava(int version) {
             Preconditions.checkArgument(version == 6 || version == 7 || version == 8, "Supported
Java versions are 6, 7, or 8");
             List<String> commands = new LinkedList<String>();
    +        commands.add(ok(addOpenJDKPPK()));
    --- End diff --
    
    Shouldn't you wrap this in a `ifExecutableElse1` instead of `ok`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message