brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...
Date Mon, 10 Apr 2017 16:11:45 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/625#discussion_r110697978
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/javalang/Reflections.java
---
    @@ -204,6 +209,7 @@ public Object loadInstance(String classname) throws ReflectionNotFoundException,
         }
     
         /** does not look through ancestors of outer class */
    +    /** @deprecated since 0.11.0, use {@link org.apache.brooklyn.util.core.ClassLoaderUtils}
in a combination with {@link #invokeConstructorFromArgs(Class, Object...)} instead */
    --- End diff --
    
    `Reflections` is in `utils-common`, while `ClassLoaderUtils` is in `core`. Could move
the string based methods to another utility class into `core`.  If the caller is going to
be constructing the `ClassLoaderUtils` there's not much to gain from it though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message