brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...
Date Mon, 10 Apr 2017 16:04:40 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/
    @@ -103,12 +103,13 @@ private void updateFromBrooklynProperties(ManagementContext mgmt)
                 BrooklynProperties config = ConfigUtils.filterForPrefixAndStrip(externalProviderProperties,
key + ".");
                 try {
    -                Maybe<ExternalConfigSupplier> configSupplier = Reflections.invokeConstructorFromArgs(classloader,
ExternalConfigSupplier.class, providerClassname, mgmt, name, config);
    +                Class<ExternalConfigSupplier> supplierClass = (Class<ExternalConfigSupplier>)new
ClassLoaderUtils(this, mgmt).loadClass(providerClassname);
    +                Maybe<ExternalConfigSupplier> configSupplier = Reflections.invokeConstructorFromArgs(supplierClass,
mgmt, name, config);
                     if (!configSupplier.isPresent()) {
    --- End diff --
    I think we should only try to load `supplierClass` if `configSupplier` is absent (i.e.
move that line to inside the if below.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message