brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #625: Updates BasicExternalConfigSupplierRegistry to u...
Date Mon, 10 Apr 2017 14:27:24 GMT
Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/625
  
    Looks good.
    Can you add test coverage in `ExternalConfigBrooklynPropertiesTest` by implementing a
dummy `ExternalConfigSupplier` in 
     * `brooklyn-server/utils/common/dependencies/osgi/com-example-entities/src/main/java/com/example/brooklyn/test/osgi`
and trying to load it with a bundle prefix
      * `brooklyn-server/utils/common/dependencies/osgi/entities/src/main/java/org/apache/brooklyn/test/osgi`
and trying to load it without prefix.
    
    To add the bundle to the osgi cache follow the example in `ClassLoaderUtilsTest.installBundle(ManagementContext,
String)` to load the bundle from the classpath.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message