brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #622: Integration tests fixes
Date Mon, 10 Apr 2017 08:25:36 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/622#discussion_r110596919
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindTestUtils.java
---
    @@ -238,7 +238,6 @@ public LocalManagementContext buildUnstarted() {
                         classLoader);
                 ((RebindManagerImpl) unstarted.getRebindManager()).setPeriodicPersistPeriod(persistPeriod);
                 unstarted.getRebindManager().setPersister(newPersister, PersistenceExceptionHandlerImpl.builder().build());
    -            unstarted.getHighAvailabilityManager().disabled();
    --- End diff --
    
    Not sure about the implications of removing this. It seems reasonable that we execute
the HA code-path in our tests, so I think this is fine. I take it that some of our integration
tests assumd that it's enabled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message