brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #617: Persist management plane ID
Date Fri, 07 Apr 2017 11:09:46 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/617#discussion_r110366800
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java
---
    @@ -382,6 +401,8 @@ protected void persistNowInternal(boolean alreadyHasMutex) {
                 if (!alreadyHasMutex) persistingMutex.acquire();
                 if (!isActive() && state != ListenerState.STOPPING) return;
                 
    +            updatePlaneIdIfTimedOut();
    --- End diff --
    
    Hm; if they are lossy then for planeId would we need to write it using a "keep trying
and double-check until successful" approach?  I.e. don't progress until write is confirmed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message