brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #617: Persist management plane ID
Date Fri, 07 Apr 2017 10:47:58 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/617#discussion_r110363846
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java
---
    @@ -456,6 +460,12 @@ else if (startMode==HighAvailabilityMode.HOT_STANDBY && getNodeState()==Manageme
                 registerPollTask();
         }
     
    +    protected void updatePlaneId(ManagementPlaneSyncRecord existingMaster) {
    --- End diff --
    
    Renaming to `updateLocalPlaneId`. It would be surprising to update with a different planeId,
but I decided to support the use case where someone goes and edits the persisted state planeId.
In case the planeId is different it will log a warning, but will accept the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message