brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...
Date Wed, 05 Apr 2017 16:33:40 GMT
Github user bostko commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r109965279
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
    @@ -227,7 +239,49 @@ protected Object getDecorationAttributeJsonValue(ConfigBag attrs)
{
     
             @Override
             protected void addDecorationFromJsonMap(Map<?, ?> decorationJson, List<SpecParameter<?>>
decorations) {
    -            throw new IllegalStateException("Not called");
    +            throw new UnsupportedOperationException("SpecParameterResolver.addDecorationFromJsonMap
should never be called.");
    +        }
    +    }
    +
    +    public static class TagsResolver extends BrooklynEntityDecorationResolver<Iterable<Object>>
{
    +        protected TagsResolver(BrooklynYamlTypeInstantiator.Factory instantiator) {
    +            super(instantiator);
    +        }
    +
    +        @Override
    +        public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs, Set<String>
encounteredRegisteredTypeIds) {
    +            Iterable<Object> decorationAttributeJsonValue = getDecorationAttributeJsonValue(attrs);
    +            if (decorationAttributeJsonValue != null) {
    +                entitySpec.tagsAdd(decorationAttributeJsonValue);
    +            }
    +        }
    +
    +        @Override
    +        protected String getDecorationKind() {
    +            return "Brooklyn Tags";
    +        }
    +
    +        @Override
    +        protected Iterable<Object> getDecorationAttributeJsonValue(ConfigBag attrs)
{
    +            Object brooklynTags = attrs.getStringKey(BrooklynCampReservedKeys.BROOKLYN_TAGS);
    +            if (brooklynTags == null) {
    +                return null;
    +            } else if (!(brooklynTags instanceof List)) {
    +                throw new IllegalArgumentException(BrooklynCampReservedKeys.BROOKLYN_TAGS
+ " should be a List of String elements. You supplied " + brooklynTags);
    +            } else {
    +                checkArgument(Iterables.all((List) brooklynTags, new Predicate() {
    +                    @Override
    +                    public boolean apply(Object input) {
    +                        return !(input instanceof DeferredSupplier) && (input
instanceof Serializable);
    --- End diff --
    
    Still `NamedStringTag` is marked as `Serializable`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message