brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #617: Persist management plane ID
Date Wed, 05 Apr 2017 16:10:54 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/617#discussion_r109941412
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java
---
    @@ -456,6 +460,12 @@ else if (startMode==HighAvailabilityMode.HOT_STANDBY && getNodeState()==Manageme
                 registerPollTask();
         }
     
    +    protected void updatePlaneId(ManagementPlaneSyncRecord existingMaster) {
    --- End diff --
    
    The parameter name sounds wrong here.  Also the method name suggested initially to me
that it was going to update something in persistence, whereas all that it does is set the
value in the local management context object; so maybe call it `updateManagementContextWithPlaneIdIfNotNull`?
    
    Is there a need in here to check whether the management context already has a plane id?
 What would be the right behaviour if it did?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message