Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-589-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-589-brooklyn-server@git.apache.org>
Subject: =?utf-8?q?=5BGitHub=5D_brooklyn-server_issue_=23589=3A_yaml-test_assertions=3A_fix_use_of_=E2=80=9Cmatches=E2=80=9D?=
Content-Type: text/plain
Message-Id: <20170311114821.73452DFE1E@git1-us-west.apache.org>
Date: Sat, 11 Mar 2017 11:48:21 +0000 (UTC)
archived-at: Sat, 11 Mar 2017 11:48:24 -0000

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/589
  
    +1 for `containsMatch` (or just `contains`) with `MULTILINE` + `DOTALL`.
    It covers all use cases:
      * simple contains: `xxx`
      * match all: `^.*xxx.*$`
      * match single line: `(^|\n)xxx(\n|$)`
      * match across lines: `expected value:\n\txxx`
    
    Most of our tests are the "simple contains" case anyway.
    
    I think it's still worth changing `matches` to `MULTILINE` + `DOTALL`. For existing single-line tests there's no change and for multi-line results it's more natural (much like the IDE search works).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---