brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #611: Deprecate groovy
Date Fri, 24 Mar 2017 18:21:35 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/611

    Deprecate groovy

    As discussed on the dev@brooklyn mailing list (subject "[PROPOSAL] Remove groovy dependency/support").
    
    Deprecate methods that take explicit groovy types (e.g. `groovy.lang.Closure`, `groovy.time.TimeDuration`,
etc).
        
    Also updates some javadoc that mentioned `Closure` to say that its usage is deprecated.
    
    In some places, it does a `LOG.warn()` about the deprecation when a groovy Closure etc
is passed in - this is when we can't just deprecate the method, e.g. for use of `TypeCoercion`
on when the method takes `Object` and does an ugly `instanceof`.
    
    This does not touch:
    * The `org.apache.brooklyn.rest.resources.ScriptResource` (for groovy-script execution)
    * Internal usage of groovy (e.g. `AbstractManagementContext.invokeEffectorMethodLocal()`
calling `GroovyJavaMethods.invokeMethodOnMetaClass`)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server deprecate-groovy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #611
    
----
commit dea3efca3238aab52564e816dc572686b63f3150
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-03-24T18:04:45Z

    Deprecate groovy methods
    
    Deprecate methods that take explicit groovy types (e.g. groovy.lang.Closure,
    groovy.time.TimeDuration, etc).
    
    Also updates some javadoc that mentioned “Closure” to say that its
    Usage is deprecated.

commit 1d52e2e468bdf3bf83ec1b61279c197577fb3e10
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-03-24T18:15:38Z

    Deprecate passing groovy to Brooklyn Main

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message