brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #598: Fix rebind for classrename with bundle pr...
Date Thu, 16 Mar 2017 00:22:53 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/598

    Fix rebind for classrename with bundle prefix

    The historic persisted state added here for testing comes from a clocker.io blueprint.
    
    The "Fix classRenames for SshPollConfig anonymous classes" is me playing it safe, to re-add
the anonymous inner classes that might be referenced by customers out there. As the comment
in the code says, we can't just use `deserializingClassRenames.properties`, because persistence
format for a static versus anonymous (non-static) inner class is different.
    
    For the "Fix xstream deserialising osgi class renames", I discussed this with @neykov
first. We both agreed that we don't particularly like the fix, but that at least it's localised
and it fixes the problem (which is causing rebind to older versions of Brooklyn to fail).
We'd like to revisit this, and see about pushing the calls to the class-renames into `ClassLoaderUtils`
perhaps. But that's a separate discussion, not for this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix-rebind-classrename-failure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #598
    
----
commit ad73fcf99676b4c06e30ac6f1ed1093225087f05
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-03-16T00:04:03Z

    Fix classRenames for SshPollConfig anonymous classes

commit bcaf76bc8e5825c765d6511541ca5edb3372d6b0
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-03-15T19:24:24Z

    Testing rebind of SshFeed (historic state)

commit 1482bf0cfc725478ad48ffc101896e62aeee2bfc
Author: Aled Sage <aled.sage@gmail.com>
Date:   2017-03-15T19:20:43Z

    Fix xstream deserialising osgi class renames
    
    i.e. where the class name in the persisted state includes the
    bundle symbolic name as a prefix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message