brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #590: Use boolean Options correctly in ItemList...
Date Mon, 13 Mar 2017 11:26:17 GMT
GitHub user sjcorbett opened a pull request:

    https://github.com/apache/brooklyn-server/pull/590

    Use boolean Options correctly in ItemLister

    Replaces list-objects' `--catalog-only` and `--ignore-impls` arguments with `--all-classes`
and `--include-impls` respectively.
    
    ItemLister defined a few options as booleans whose default was true. Airline treats boolean
options as having zero arity and whose existence implies truth. See Airline's [MetadataLoader](https://github.com/airlift/airline/blob/0.7/src/main/java/io/airlift/airline/model/MetadataLoader.java#L156)
class.
    
    I've removed the default from all other boolean options to make it clearer that the value
is set by Airline.
    
    CloudExplorerLiveTest passes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/brooklyn-server fix/item-lister

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #590
    
----
commit 3bb2b2b8f4cda014ad543432da16be38b49eaa2e
Author: Sam Corbett <sam.corbett@cloudsoftcorp.com>
Date:   2017-03-13T10:41:17Z

    Use Airline 0.7

commit 786b9388f5e293dc62ca8e02e00cc2ec27110977
Author: Sam Corbett <sam.corbett@cloudsoftcorp.com>
Date:   2017-03-13T10:45:41Z

    Format enrichers to make them easier to read on screens that aren't enormous

commit 8e4fc1740d6a1768d5e2315fe65c59ab10590c39
Author: Sam Corbett <sam.corbett@cloudsoftcorp.com>
Date:   2017-03-13T11:17:36Z

    Use boolean Options correctly in ItemLister
    
    Replaces list-objects' --catalog-only and --ignore-impls arguments with
    --all-classes and --include-impls respectively.
    
    ItemLister defined a few options as booleans whose default was true.
    Airline treats boolean options as having zero arity and whose existence
    implies truth.
    
    Also removes the default from all other boolean options to make it
    clearer that the value is set by Airline.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message