brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BROOKLYN-460) Brooklyn Camp syntax for adding tags to an entity spec
Date Fri, 31 Mar 2017 11:37:41 GMT


ASF GitHub Bot commented on BROOKLYN-460:

Github user aledsage commented on a diff in the pull request:
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/
    @@ -257,6 +257,7 @@ public boolean canResolve() {
             new BrooklynEntityDecorationResolver.EnricherSpecResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
             new BrooklynEntityDecorationResolver.InitializerResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
             new BrooklynEntityDecorationResolver.SpecParameterResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
    +        new BrooklynEntityDecorationResolver.TagsResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
    --- End diff --
    Thanks @neykov - makes sense. However, a much bigger topic is how we really should be
defining effectors/feeds in yaml. To me, the `brooklyn.initializers` feels like a powerful
hack - re-using a generic feature to add things that are fundamental to blueprints. I think
it's confusing for users to have to use `brooklyn.initializers` rather than us having first-class
`brooklyn.effectors`. But let's not discuss that here - it can be a dev@brooklyn discussion
when we're ready!

> Brooklyn Camp syntax for adding tags to an entity spec
> ------------------------------------------------------
>                 Key: BROOKLYN-460
>                 URL:
>             Project: Brooklyn
>          Issue Type: New Feature
>            Reporter: Valentin Aitken
>            Priority: Minor
> Current requirement is to be able to supply String tags in an entity spec in YAML so
it can be then retrieved via REST API with {{GET /v1/applications/<appId>/entities/<entityId>/tags}}.
> Example usage in a YAML blueprint:
> {noformat}
> services:
> - type:
>   brooklyn.tags:
>   - tag1
>   - tag2
> {noformat}
> Please shout if you have further requirements for {{brooklyn.tags}}.

This message was sent by Atlassian JIRA

View raw message