brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BROOKLYN-460) Brooklyn Camp syntax for adding tags to an entity spec
Date Wed, 29 Mar 2017 10:17:42 GMT


ASF GitHub Bot commented on BROOKLYN-460:

Github user neykov commented on a diff in the pull request:
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/
    @@ -257,6 +257,7 @@ public boolean canResolve() {
             new BrooklynEntityDecorationResolver.EnricherSpecResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
             new BrooklynEntityDecorationResolver.InitializerResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
             new BrooklynEntityDecorationResolver.SpecParameterResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
    +        new BrooklynEntityDecorationResolver.TagsResolver(yamlLoader).decorate(spec,
attrs, encounteredRegisteredTypeIds);
    --- End diff --
    @tbouron is onto something here. For example for effectors we go through an initializer
and try not to expand the keywords too much.
    I think that anything that is a "first class concept" on an `EntitySpec` should have the
corresponding way to express in yaml. There are tags on specs, so `brooklyn.tags` in CAMP
makes sense. Similarly for `brooklyn.parameters`, `brooklyn.config`. There are no effectors
on the `EntitySpec` so there are no `brooklyn.effectors` in CAMP.

> Brooklyn Camp syntax for adding tags to an entity spec
> ------------------------------------------------------
>                 Key: BROOKLYN-460
>                 URL:
>             Project: Brooklyn
>          Issue Type: New Feature
>            Reporter: Valentin Aitken
>            Priority: Minor
> Current requirement is to be able to supply String tags in an entity spec in YAML so
it can be then retrieved via REST API with {{GET /v1/applications/<appId>/entities/<entityId>/tags}}.
> Example usage in a YAML blueprint:
> {noformat}
> services:
> - type:
>   brooklyn.tags:
>   - tag1
>   - tag2
> {noformat}
> Please shout if you have further requirements for {{brooklyn.tags}}.

This message was sent by Atlassian JIRA

View raw message