brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-460) Brooklyn Camp syntax for adding tags to an entity spec
Date Wed, 29 Mar 2017 09:50:42 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946853#comment-15946853
] 

ASF GitHub Bot commented on BROOKLYN-460:
-----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r108630028
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
    @@ -59,6 +59,21 @@ public String getKind() {
             public String getContents() {
                 return contents;
             }
    +
    +        @Override
    +        public boolean equals(Object other) {
    +            if (other == null || !(other instanceof NamedStringTag)) {
    +                return false;
    +            }
    +
    +            return kind != null && kind.equals(((NamedStringTag)other).kind)
    --- End diff --
    
    This will return not equals if both have `kind == null` and/or `contents == null`. Better
to do:
    ```
    if (!(other instanceof NamedStringTag)) {
        return false;
    }
    NamedStringTag o = (NamedStringTag) other;
    return Objects.equal(kind, o.kind) && Objects.equal(contents, o.contents);
    ```


> Brooklyn Camp syntax for adding tags to an entity spec
> ------------------------------------------------------
>
>                 Key: BROOKLYN-460
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-460
>             Project: Brooklyn
>          Issue Type: New Feature
>            Reporter: Valentin Aitken
>            Priority: Minor
>
> Current requirement is to be able to supply String tags in an entity spec in YAML so
it can be then retrieved via REST API with {{GET /v1/applications/<appId>/entities/<entityId>/tags}}.
> Example usage in a YAML blueprint:
> {noformat}
> services:
> - type: org.apache.brooklyn.entity.software.base.VanillaSoftwareProcess
>   brooklyn.tags:
>   - tag1
>   - tag2
> {noformat}
> Please shout if you have further requirements for {{brooklyn.tags}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message