brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #589: yaml-test assertions: fix use of “matches”
Date Wed, 29 Mar 2017 10:45:01 GMT
Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-server/pull/589
  
    @aledsage My assumption was that those flags **were not** language specific, my bad.
    
    I think I will side with @geomacy and [his radical idea](https://github.com/apache/brooklyn-server/pull/589#issuecomment-285778134)
=> not touching the code but adding documentation on how to support multiline via the `(?s)`
flag. I know it is java specific but the Brooklyn codebase is java, I don't see any reason
against using it.
    
    Personally, I do prefer be in charge of what to match rather than letting Brooklyn trying
to be smart and possibly fail.
    
    That being said, I'm happy to go with what the majority think it's best


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message