brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...
Date Wed, 29 Mar 2017 09:50:01 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r108632848
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
    @@ -227,7 +234,54 @@ protected Object getDecorationAttributeJsonValue(ConfigBag attrs)
{
     
             @Override
             protected void addDecorationFromJsonMap(Map<?, ?> decorationJson, List<SpecParameter<?>>
decorations) {
    -            throw new IllegalStateException("Not called");
    +            throw new UnsupportedOperationException("SpecParameterResolver.addDecorationFromJsonMap
should never be called.");
    +        }
    +    }
    +
    +    public static class TagsResolver extends BrooklynEntityDecorationResolver<Iterable<Object>>
{
    +        protected TagsResolver(BrooklynYamlTypeInstantiator.Factory instantiator) {
    +            super(instantiator);
    +        }
    +
    +        @Override
    +        public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs, Set<String>
encounteredRegisteredTypeIds) {
    +            if (getDecorationAttributeJsonValue(attrs) != null) {
    +                entitySpec.tagsAdd((Iterable<Object>)getDecorationAttributeJsonValue(attrs));
    +            }
    +        }
    +
    +        @Override
    +        protected String getDecorationKind() {
    +            return "Brooklyn Tags";
    +        }
    +
    +        @Override
    +        protected Object getDecorationAttributeJsonValue(ConfigBag attrs) {
    +            Object brooklynTags = attrs.getStringKey(BrooklynCampReservedKeys.BROOKLYN_TAGS);
    +            if (brooklynTags == null) {
    +                return null;
    +            } else if (brooklynTags != null && !(brooklynTags instanceof List))
{
    +                throw new IllegalArgumentException(BrooklynCampReservedKeys.BROOKLYN_TAGS
+ " should be a List of String elements. You supplied " + attrs);
    +            } else {
    +                checkArgument(Iterables.all((List) brooklynTags, new Predicate() {
    +                    @Override
    +                    public boolean apply(@Nullable Object input) {
    +                        return input instanceof String;
    --- End diff --
    
    Is this too strict? What about primitives? I tried the yaml below, and it failed at this
assertion (because it has the int `2`):
    ```
    services:
    - type: org.apache.brooklyn.entity.stock.BasicApplication
      brooklyn.tags:
      - tag1
      - 2
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message