brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #612: Brooklyn Camp syntax for adding tags to a...
Date Wed, 29 Mar 2017 09:19:17 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r108628511
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
    @@ -230,4 +237,51 @@ protected void addDecorationFromJsonMap(Map<?, ?> decorationJson,
List<SpecParam
                 throw new IllegalStateException("Not called");
    --- End diff --
    
    As per @tbouron's comment about whether to implement this - throwing an exception saying
"Not called" is very misleading. If it is ever called, then telling the user that it wasn't
called in the exception message will look weird!
    
    Better to have a comment saying that it won't be called, and to throw an `UnsupportedOperationException`
I think.
    
    But it looks like this code already existed, rather than being modified in this PR (so
doesn't need to be fixed here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message