brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #605: Add series of meta effectors for composit...
Date Tue, 28 Mar 2017 16:15:18 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/605#discussion_r108466870
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/composite/AbstractCompositeEffector.java
---
    @@ -0,0 +1,184 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.core.effector.composite;
    +
    +import java.util.Map;
    +import java.util.Set;
    +
    +import org.apache.brooklyn.api.effector.Effector;
    +import org.apache.brooklyn.api.entity.Entity;
    +import org.apache.brooklyn.api.entity.EntityLocal;
    +import org.apache.brooklyn.core.effector.AddEffector;
    +import org.apache.brooklyn.core.effector.EffectorBody;
    +import org.apache.brooklyn.util.collections.CollectionFunctionals;
    +import org.apache.brooklyn.util.core.config.ConfigBag;
    +import org.apache.brooklyn.util.guava.Maybe;
    +import org.apache.brooklyn.util.text.Strings;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.annotations.Beta;
    +import com.google.common.collect.Iterables;
    +
    +@Beta
    +public abstract class AbstractCompositeEffector extends AddEffector {
    +
    +    private static final Logger LOG = LoggerFactory.getLogger(AbstractCompositeEffector.class);
    +
    +    public AbstractCompositeEffector(Effector<?> effector) {
    +        super(effector);
    +    }
    +
    +    @Override
    +    public void apply(EntityLocal entity) {
    +        Maybe<Effector<?>> effectorMaybe = entity.getEntityType().getEffectorByName(effector.getName());
    +        if (!effectorMaybe.isAbsentOrNull()) {
    +//            Effector<?> original = Effectors.effector(effectorMaybe.get()).name(ORIGINAL_PREFIX
+ effector.getName()).build();
    +//            ((EntityInternal) entity).getMutableEntityType().addEffector(original);
    +        }
    +        super.apply(entity);
    +    }
    +
    +    protected static abstract class Body<T> extends EffectorBody<T> {
    +        protected final Effector<?> effector;
    +        protected final ConfigBag params;
    +
    +        public Body(Effector<?> eff, ConfigBag params) {
    +            this.effector = eff;
    +            this.params = params;
    +        }
    +
    +        @Override
    +        public abstract T call(final ConfigBag params);
    +
    +        protected String getEffectorName(Object effectorDetails) {
    +            String effectorName = null;
    +            if (effectorDetails instanceof String) {
    +                effectorName = (String) effectorDetails;
    +            } else if (effectorDetails instanceof Map) {
    +                Map<String,Object> effectorMap = (Map) effectorDetails;
    +                Set<String> keys = effectorMap.keySet();
    +                if (keys.size() != 1) {
    +                    throw new IllegalArgumentException("Effector parameter cannot be
parsed: " + effectorDetails);
    +                }
    +                effectorName = Iterables.getOnlyElement(keys);
    +            } else {
    --- End diff --
    
    But why would they do that? They would be creating a list of lists, as in the third option
below, and if someone does that, then I'm happy for things to just break...
    
    ```YAML
    compose:
      - name1 # string
      - name2: # map
          key: value
      - [ whyWouldYouDoThis ] # list
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message