brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #611: Deprecate groovy
Date Tue, 28 Mar 2017 10:09:51 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/611#discussion_r108372912
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/ExplicitEffector.java ---
    @@ -46,12 +58,20 @@ public T call(Entity entity, Map parameters) {
         
         /** convenience to create an effector supplying a closure; annotations are preferred,
          * and subclass here would be failback, but this is offered as 
    -     * workaround for bug GROOVY-5122, as discussed in test class CanSayHi 
    +     * workaround for bug GROOVY-5122, as discussed in test class CanSayHi.
    +     * 
    +     * @deprecated since 0.11.0; explicit groovy utilities/support will be deleted.
          */
    +    @Deprecated
         public static <I,T> ExplicitEffector<I,T> create(String name, Class<T>
type, List<ParameterType<?>> parameters, String description, Closure body) {
    +        LOG.warn("Use of groovy.lang.Closure is deprecated, in ExplicitEffector.create()");
    --- End diff --
    
    Shouldn't we suggest another class/method to use in the warning message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message