brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #612: Brooklyn Camp syntax for adding tags to a...
Date Tue, 28 Mar 2017 09:18:31 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/612#discussion_r108371784
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
    @@ -230,4 +234,45 @@ protected void addDecorationFromJsonMap(Map<?, ?> decorationJson,
List<SpecParam
                 throw new IllegalStateException("Not called");
             }
         }
    +
    +    public static class TagsResolver extends BrooklynEntityDecorationResolver<Iterable<Object>>
{
    +        protected TagsResolver(BrooklynYamlTypeInstantiator.Factory instantiator) {
    +            super(instantiator);
    +        }
    +
    +        @Override
    +        public void decorate(EntitySpec<?> entitySpec, ConfigBag attrs, Set<String>
encounteredRegisteredTypeIds) {
    +            if (getDecorationAttributeJsonValue(attrs) != null) {
    +                entitySpec.tagsAdd((Iterable<Object>)getDecorationAttributeJsonValue(attrs));
    +            }
    +        }
    +
    +        @Override
    +        protected String getDecorationKind() {
    +            return "Brooklyn Tags";
    +        }
    +
    +        @Override
    +        protected Object getDecorationAttributeJsonValue(ConfigBag attrs) {
    +            Object brooklynTags = attrs.getStringKey(BrooklynCampReservedKeys.BROOKLYN_TAGS);
    +            if (brooklynTags == null) {
    +                return null;
    +            } else if (brooklynTags != null && !(brooklynTags instanceof List))
{
    +                throw new IllegalArgumentException("brooklyn.tags should be a List of
strings " + attrs);
    +            } else {
    +                return Iterables.transform((List)brooklynTags, new Function<String,
BrooklynTags.NamedStringTag>() {
    +                    @Nullable
    +                    @Override
    +                    public BrooklynTags.NamedStringTag apply(@Nullable String input)
{
    +                        return BrooklynTags.newNotesTag(input);
    +                    }
    +                });
    +            }
    +        }
    +
    +        @Override
    +        protected void addDecorationFromJsonMap(Map<?, ?> decorationJson, List<Iterable<Object>>
decorations) {
    +            throw new IllegalStateException("Not called");
    --- End diff --
    
    Is it right to not implement this? Or at least, shouldn't we have a better exception message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message