brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #605: Add series of meta effectors for composit...
Date Fri, 24 Mar 2017 12:37:45 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/605#discussion_r107892815
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/composite/ComposeEffector.java
---
    @@ -0,0 +1,109 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.core.effector.composite;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +import org.apache.brooklyn.api.effector.Effector;
    +import org.apache.brooklyn.api.entity.Entity;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +import org.apache.brooklyn.core.effector.AddEffector;
    +import org.apache.brooklyn.core.effector.EffectorBody;
    +import org.apache.brooklyn.core.effector.Effectors.EffectorBuilder;
    +import org.apache.brooklyn.core.entity.EntityInitializers;
    +import org.apache.brooklyn.util.core.config.ConfigBag;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.google.common.annotations.Beta;
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.reflect.TypeToken;
    +
    +@Beta
    +public class ComposeEffector extends AbstractCompositeEffector {
    +
    +    private static final Logger LOG = LoggerFactory.getLogger(ComposeEffector.class);
    +
    +    public static final ConfigKey<List<Object>> COMPOSE = ConfigKeys.newConfigKey(
    +            new TypeToken<List<Object>>() { },
    +            "compose",
    +            "Effector details list for the compose effector",
    +            ImmutableList.<Object>of());
    +
    +    public ComposeEffector(ConfigBag params) {
    +        super(newEffectorBuilder(params).build());
    +    }
    +
    +    public ComposeEffector(Map<?, ?> params) {
    +        this(ConfigBag.newInstance(params));
    +    }
    +
    +    public static EffectorBuilder<Object> newEffectorBuilder(ConfigBag params)
{
    +        EffectorBuilder<Object> eff = AddEffector.newEffectorBuilder(Object.class,
params);
    +        EffectorBody<Object> body = new Body(eff.buildAbstract(), params);
    +        eff.impl(body);
    +        return eff;
    +    }
    +
    +    protected static class Body extends AbstractCompositeEffector.Body<Object>
{
    +
    +        public Body(Effector<?> eff, ConfigBag params) {
    +            super(eff, params);
    +            Preconditions.checkNotNull(params.getAllConfigRaw().get(COMPOSE.getName()),
"Effector names must be supplied when defining this effector");
    --- End diff --
    
    Yes, I'll fix all of these to have better error messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message