brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #485: `BundleMaker` REST call allowing to add Z...
Date Wed, 22 Mar 2017 10:48:09 GMT
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/485#discussion_r107382103
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -417,6 +419,53 @@ else for (String key: otherKeys) {
             return result;
         }
     
    +    public static Map<?,?> getCatalogMetadata(String yaml) {
    +        Map<?,?> itemDef = Yamls.getAs(Yamls.parseAll(yaml), Map.class);
    +        return getFirstAsMap(itemDef, "brooklyn.catalog").orNull();        
    +    }
    +    
    +    public static VersionedName getVersionedName(Map<?,?> catalogMetadata) {
    +        String id = getFirstAs(catalogMetadata, String.class, "id").orNull();
    +        String version = getFirstAs(catalogMetadata, String.class, "version").orNull();
    +        String symbolicName = getFirstAs(catalogMetadata, String.class, "symbolicName").orNull();
    +        symbolicName = findAssertingConsistentIfSet("symbolicName", symbolicName, getFirstAs(catalogMetadata,
String.class, "symbolic-name").orNull());
    --- End diff --
    
    I revised my comment, the `catalogMetata` is the catalog metadata that comes only from
the yaml. So I agree with @aledsage, we should support only `symbolicName`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message