brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-docs pull request #155: Brooklyn.initializers example with sensor f...
Date Wed, 15 Mar 2017 15:19:06 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-docs/pull/155#discussion_r106193454
  
    --- Diff: guide/yaml/yaml-reference.md ---
    @@ -58,7 +58,7 @@ the entity being defined, with these being the most common:
         and optionally a `period`, to create a sensor feed which populates the sensor with
         the given name by running the given command (on an entity which as an ssh-able machine)
     
    -  * `org.apache.brooklyn.core.sensor.windows.WinRmCommandSensor`: For command supplied
via WinRm. Takes a `name` and `command`,
    +  * `org.apache.brooklyn.core.sensor.windows.WinRmCommandSensor`: For command supplied
via WinRm. Takes a `name`, `command`, `executionDir`,
    --- End diff --
    
    Seems `executionDir` is required right now, otherwise it will error out - worth mentioning
it here. LGTM otherwise.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message