brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #593: BROOKLYN-451: Adds yaml-dsl rebind tests ...
Date Tue, 14 Mar 2017 17:21:39 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/593#discussion_r105973026
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/xstream/XmlSerializer.java
---
    @@ -80,6 +80,11 @@ protected MapperWrapper wrapMapper(MapperWrapper next) {
     
             xstream.registerConverter(new EnumCaseForgivingConverter());
             xstream.registerConverter(new Inet4AddressConverter());
    +        
    +        // See ObjectWithDefaultStringImplConverter (and its usage) for why we want to
auto-detect 
    +        // annotations (usages of this is in the camp project, so we can't just list
it statically
    +        // here unfortunately).
    +        xstream.autodetectAnnotations(true);
    --- End diff --
    
    Seems to be about 5-10% overhead (when testing with a simple EntityMemento that has lots
of string keys and brooklyn.parameters). That's certainly acceptable, to fix the issue!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message