brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Date Wed, 08 Mar 2017 17:20:39 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r104922028
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java
---
    @@ -318,4 +327,26 @@ public static void setDisabled(ManagementContext mgmt, String symbolicName,
Stri
             mgmt.getCatalog().persist(item);
         }
     
    +    public static BrooklynClassLoadingContextSequential newClassLoadingContextForCatalogItems(
    --- End diff --
    
    Have done `ClassLoaderUtils:229` and `BrooklynMementoPersisterToObjectStore:189`, but
`XmlMementoSerializer` is calling `newClassLoadingContext(ManagementContext mgmt, RegisteredType
item)` rather than `ewClassLoadingContext(ManagementContext mgmt, CatalogItem<?, ?>
item)`, and the hierarchy is not available on `RegisteredType`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message