brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #338: Support nested catalog item definitions - testCa...
Date Mon, 06 Mar 2017 11:49:21 GMT
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/338
  
    Thanks @ahgittin I will have a look at #573 hopefully today or very soon.  Nice to have
extra tests!
    
    Regarding the persistence,  basically in the persisted XML my change replaces `<catalogItemId>`
with the hierarchy of the catalog ids that defined the item (so if `foo` is defined as an
extension of `bam` which is in turn a `bar`, you get
    ```
    <catalogItemIdHierarchy>
      <string>foo</string>
      <string>bam</string>
      <string>bar</string>
    </catalogItemIdHierarchy>
    ```
    so I am continuing to populate and persist catalogItemId, just implemented as this list.
Also I have code in place to handle previously persisted state (still using `<catalogItemId>foo</catalogItemId>`)
and load it into this new model. 
    
    Re. the question of upgrades from 1.0 to 2.0 I will need to have a look at it, I can't
remember what the test coverage is like for this scenario (I think there are some tests).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message