Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-462-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-462-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #462: Inherit config default values
Content-Type: text/plain
Message-Id: <20170213144549.3748CDFC31@git1-us-west.apache.org>
Date: Mon, 13 Feb 2017 14:45:49 +0000 (UTC)
archived-at: Mon, 13 Feb 2017 14:45:51 -0000

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/462#discussion_r100808041
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigInheritance.java ---
    @@ -170,12 +324,103 @@ public String getConflictResolutionStrategy() {
             return conflictResolutionStrategy;
         }
         
    +    @Deprecated /** @deprecated since 0.10.0 when it was introduced, prefer {@link #getLocalDefaultResolvesWithAncestorValue()} */
         public boolean getUseLocalDefaultValue() {
    -        return useLocalDefaultValue;
    +        return getLocalDefaultResolvesWithAncestorValue();
    +    }
    +
    +    /** see {@link #localDefaultResolvesWithAncestorValue} */
    +    public boolean getLocalDefaultResolvesWithAncestorValue() {
    +        if (localDefaultResolvesWithAncestorValue==null) {
    +            // in case some legacy path is using an improperly deserialized object
    +            log.warn("Encountered legacy "+this+" with null localDefaultResolvesWithAncestorValue; transforming", new Throwable("stack trace for legacy "+this));
    +            readResolve();
    --- End diff --
    
    i think this should never happen; logging is safety first in case it is


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---