brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <>
Subject [GitHub] brooklyn-server pull request #564: Winrm CmdFeed
Date Fri, 17 Feb 2017 17:31:30 GMT
GitHub user bostko opened a pull request:

    Winrm CmdFeed

    Please, review commits one by one to have better differences view.
    PR can be considered as WIP however I think it is in good shape.
    The PR moves SshFeed to AbstractCommandFeed. This way it can be reused by ShellFeed and
also for Windows based command.
    TODOs which I will try to do in additional commits.
    1. Add SshFeed rebind test
    1. Add software/winrm/src/main/java/org/apache/brooklyn/sensor/windows/
    1. Consider changing SshPollValue to CommandPollValue
    1. Make an abstract CommandFeedIntegrationTest

You can merge this pull request into a Git repository by running:

    $ git pull winrm_command_sensor

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #564
commit 89f503090e26a11af8a9f05ee0c1d23f0da8f4a7
Author: Valentin Aitken <>
Date:   2017-02-14T17:23:21Z

    Move SshFeed to AbstractCommandFeed

commit 9a47a471458f5a35ae61e87e08b61dc0415328f3
Author: Valentin Aitken <>
Date:   2017-02-16T14:40:18Z

    Move ssh/SshPollConfig to CommandPollConfig

commit af05f92da646f8b14b27265abebba064263324bb
Author: Valentin Aitken <>
Date:   2017-02-16T16:03:50Z

    Extract AbstractCommandFeed from SshFeed
    - Added windows.CmdFeed

commit 5e74119180aa21cf9fcbff7f5e7d5c89c6a73c5d
Author: Valentin Aitken <>
Date:   2017-02-17T17:08:15Z

    WinRm4j: Add environment flags on initialization


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message