brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #338: Support nested catalog item definitions - testCa...
Date Tue, 28 Feb 2017 16:46:24 GMT
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/338
  
    Thanks @ahgittin and @neykov for comments; I will try to address the remaining items as
noted above (https://github.com/apache/brooklyn-server/pull/338#issuecomment-281950519) soon.
    
    I will have a look at #573 to see how this can be merged with it.
    
    Just on the point of omitting or retaining the `catalogItemId` member (https://github.com/apache/brooklyn-server/pull/338#discussion_r102679601),
 for rebind purposes, what do you think of my changes to `BrooklynMementoPersisterToObjectStore`
which as far as I can see allow me to avoid keeping that member.  I am able to re-run all
the tests from `testRebindWithCatalogAndApp` with persisted content with the format prior
to this change (see https://github.com/apache/brooklyn-server/pull/338/files#diff-3804f33dfb6d89e123adcff13f9c114dR173).
  It looked to me as if we don't need to retain that member, hence the changes above, but
if you think there's another case to cover then I can put it back (and will probably need
to think about adding more tests to catch that case).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message