brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #155: [WIP] Add DSL support for calling effectors in Y...
Date Tue, 28 Feb 2017 15:17:01 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/155
  
    Ouch -- I don't think this is a good idea.  Apologies, I hadn't reviewed it because it
was marked `[WIP]` -- in any case we shouldn't be merging WIPs :).  My main objections are
as follows:
    
    * invoking an effector is often a heavyweight task which we should do sparingly, only
exposing in the DSL if there is a compelling use case (has this been presented?), and if so
can we achieve it a better way?
    * the side-effect marker is designed to avoid that but it is likely not to be used often
and so we risk assuming things aren't side-effecting when they are
    
    And there is a minor but aggravating issue that there are other PRs I have being reviewed
which clean up immediately semantics and this clobbers them.  I think it will be easier to
put this on top of those if we decide we need it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message