brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #564: Winrm CmdFeed
Date Tue, 28 Feb 2017 14:16:02 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/564#discussion_r103459790
  
    --- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/SshPollConfig.java ---
    @@ -18,183 +18,21 @@
      */
     package org.apache.brooklyn.feed.ssh;
     
    -import static com.google.common.base.Preconditions.checkNotNull;
    -
    -import java.util.Collections;
    -import java.util.List;
    -import java.util.Map;
    -
    -import javax.annotation.Nullable;
    -
    -import com.google.common.base.Objects;
    -import com.google.common.base.Preconditions;
    -import com.google.common.base.Predicate;
    -import com.google.common.base.Supplier;
    -import com.google.common.base.Suppliers;
    -
     import org.apache.brooklyn.api.sensor.AttributeSensor;
    -import org.apache.brooklyn.core.feed.PollConfig;
    -import org.apache.brooklyn.util.collections.MutableList;
    -import org.apache.brooklyn.util.collections.MutableMap;
    -
    -public class SshPollConfig<T> extends PollConfig<SshPollValue, T, SshPollConfig<T>>
{
    -
    -    private Supplier<String> commandSupplier;
    -    private List<Supplier<Map<String,String>>> dynamicEnvironmentSupplier
= MutableList.of();
    -
    -    public static final Predicate<SshPollValue> DEFAULT_SUCCESS = new Predicate<SshPollValue>()
{
    -        @Override
    -        public boolean apply(@Nullable SshPollValue input) {
    -            return input != null && input.getExitStatus() == 0;
    -        }};
    -
    -    public static <T> SshPollConfig<T> forSensor(AttributeSensor<T>
sensor) {
    -        return new SshPollConfig<T>(sensor);
    -    }
    -
    -    public static SshPollConfig<Void> forMultiple() {
    -        return new SshPollConfig<Void>(PollConfig.NO_SENSOR);
    -    }
    +import org.apache.brooklyn.feed.CommandPollConfig;
     
    +@Deprecated
    --- End diff --
    
    Add `@deprecated since` javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message