brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From googlielmo <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features
Date Fri, 24 Feb 2017 11:34:07 GMT
Github user googlielmo commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/516#discussion_r102925419
  
    --- Diff: karaf/itests/src/test/java/org/apache/brooklyn/karaf/itests/FeatureInstallationTest.java
---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.brooklyn.karaf.itests;
    +
    +import static org.ops4j.pax.exam.CoreOptions.maven;
    +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.configureSecurity;
    +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.editConfigurationFileExtend;
    +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.editConfigurationFilePut;
    +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.karafDistributionConfiguration;
    +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.keepRuntimeFolder;
    +import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.logLevel;
    +
    +import java.io.File;
    +
    +import javax.inject.Inject;
    +
    +import org.apache.karaf.features.FeaturesService;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.ops4j.pax.exam.Configuration;
    +import org.ops4j.pax.exam.Option;
    +import org.ops4j.pax.exam.junit.PaxExam;
    +import org.ops4j.pax.exam.karaf.options.LogLevelOption;
    +import org.ops4j.pax.exam.options.MavenArtifactUrlReference;
    +import org.ops4j.pax.exam.spi.reactors.ExamReactorStrategy;
    +import org.ops4j.pax.exam.spi.reactors.PerClass;
    +
    +
    +@RunWith(PaxExam.class)
    +@ExamReactorStrategy(PerClass.class)
    +public class FeatureInstallationTest extends TestBase {
    +
    --- End diff --
    
    Had a look at this with @andreaturli who wrote the first unit tests in this PR.
    It's fair to say that at the moment this is quite similar to the `verify` phase of the
karaf-maven-plugin, especially as we're using the `PerClass` Exam reactor strategy.
    At the same time, yes we can add more tests / assertions to check the health of karaf
/ brooklyn, good point! Will add some.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message