brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...
Date Thu, 23 Feb 2017 10:12:18 GMT
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r102679856
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -187,7 +202,24 @@ public final String getDisplayName() {
         }
         
         public final String getCatalogItemId() {
    -        return catalogItemId;
    +        if (catalogItemIdStack.size() != 0) {
    +            return catalogItemIdStack.getFirst();
    +        }
    +        return null;
    --- End diff --
    
    Seems preferable not to retain catalogItemId if we can get away without it, see
    comment https://github.com/apache/brooklyn-server/pull/338#discussion_r102679601 above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message