brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #480: Config self reference fix
Date Mon, 20 Feb 2017 12:47:09 GMT
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/480
  
    All should be fixed now @aledsage 
    
    https://github.com/apache/brooklyn-server/pull/480/commits/99ccc0f6c8703e924c5fff5197bf1a0c6e39bc81
adds comments and assertions for the cancellation behaviour.  TL;DR, `TaskFactory` config
values should have their tasks cancelled, but `Task` values should _not_.  The last commit
fixes one thing which had been causing a failure in integration tests.
    
    The remaining messy/broken tests seem to be mainly around immediate not having any guarantees
due to timing.  I'd like to try to switch most/all to use the interrupting-immediate pattern,
but that'll be another PR :) .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message