brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #564: Winrm CmdFeed
Date Mon, 20 Feb 2017 07:11:20 GMT
Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/564
  
    The ssh vs winrm duality continues to propagate throughout the codebase. Is there a reason
why we don't use the common `ShellTool` interface instead (and pull up needed methods)?
    
    There are a few places where it matters what the underlying OS is, but for the most part
it's just executing commands and getting the result, without caring about the type of the
script being executed.
    
    I'm fine with merging this, but would be nice to have a discussion on how to unify the
code paths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message