brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #480: Config self reference fix
Date Sat, 18 Feb 2017 11:48:23 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/480#discussion_r101891448
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
    @@ -539,8 +550,9 @@ protected String resolveKeyName(boolean immediately) {
             @Override
             public final Maybe<Object> getImmediately() {
                 Maybe<Entity> targetEntityMaybe = component.getImmediately();
    -            if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target entity not
available");
    +            if (targetEntityMaybe.isAbsent()) return Maybe.<Object>cast(targetEntityMaybe);
                 EntityInternal targetEntity = (EntityInternal) targetEntityMaybe.get();
    +            checkAndTagForRecursiveReference(targetEntity);
    --- End diff --
    
    actually i've done a better strategy -- @aledsage appreciate any thoughts on this:
    
    ```
                    // don't check on ourself; only look higher in hierarchy;
                    // this assumes impls always spawn new tasks (which they do, just maybe
not always in new threads)
                    // but it means it does not rely on tag removal to prevent weird errors,

                    // and more importantly it makes the strategy idempotent
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message