brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #480: Config self reference fix
Date Sat, 18 Feb 2017 01:14:51 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/480#discussion_r101877977
  
    --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
---
    @@ -91,6 +96,62 @@ public void testConfigInConfigBlock() throws Exception {
             assertNull(entity.getMyField()); // field with @SetFromFlag
             assertNull(entity.getMyField2()); // field with @SetFromFlag("myField2Alias"),
set using alias
         }
    +    
    +
    +    @Test
    +    public void testRecursiveConfigFailsGracefully() throws Exception {
    +        doTestRecursiveConfigFailsGracefully(false);
    +    }
    +    
    +    // TODO this test fails because entities aren't available when evaluating immediately
    --- End diff --
    
    stale comment, good catch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message