brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #561: better presentation for sensor publishing...
Date Sat, 18 Feb 2017 00:57:24 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/561#discussion_r101876867
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java
---
    @@ -111,7 +115,7 @@ public long getTotalEventsDelivered() {
                 s.subscriberExecutionManagerTagSupplied = true;
             } else {
                 s.subscriberExecutionManagerTag = 
    -                s.subscriber instanceof Entity ? "subscription-delivery-entity-"+((Entity)s.subscriber).getId()+"["+s.subscriber+"]"
: 
    +                s.subscriber instanceof Entity ? "subscription-delivery-entity-"+((Entity)s.subscriber).getId()
: 
    --- End diff --
    
    yes, the tostring repeats the ID, adds the java type which might be nice, but really a
bit clunky imo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message