brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #480: Config self reference fix
Date Fri, 17 Feb 2017 23:40:58 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/480#discussion_r101847631
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractConfigurationSupportInternal.java
---
    @@ -146,7 +146,6 @@ public T call() {
                     .immediately(true)
                     .deep(true)
                     .context(getContext())
    -                .swallowExceptions()
    --- End diff --
    
    I probably agree with this change, but don't feel confident about the full implications
of it throwing the exception rather than returning the default value versus absent. In your
test `doTestRecursiveConfigFailsGracefully` it certainly makes sense, but not sure what else
this will affect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message