brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duncangrant <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #92: Updates couchDBNode to support V2.0+
Date Thu, 16 Feb 2017 14:24:35 GMT
Github user duncangrant commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/92#discussion_r101529086
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java
---
    @@ -198,24 +211,36 @@ public void customize() {
         @Override
         public void launch() {
             log.info("Launching  {}", entity);
    -        newScript(MutableMap.of(USE_PID_FILE, false), LAUNCHING)
    -                .body.append(String.format("nohup ./bin/couchdb -p %s -a %s -o couchdb-console.log
-e couchdb-error.log -b &", getPidFile(), Os.mergePathsUnix(getRunDir(), getCouchDBConfigFileName())))
    -                .execute();
    +        String couchDBPath = isV2()? getExpandedInstallDir()+"/rel/couchdb/bin/couchdb"
: "./bin/couchdb";
    +        ScriptHelper script = newScript(MutableMap.of(USE_PID_FILE, false), LAUNCHING);
    --- End diff --
    
    you could set USE_PID_FILE to isV2()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message