brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #462: Inherit config default values
Date Wed, 15 Feb 2017 15:43:23 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/462#discussion_r101306815
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java ---
    @@ -457,6 +457,8 @@ public boolean equals(Object obj) {
             Maybe<?> other = (Maybe<?>)obj;
             if (!isPresent()) 
                 return !other.isPresent();
    +        if (!other.isPresent())
    +            return false;
    --- End diff --
    
    Don't mind me, somehow missed the previous check where two absents will be equal.
    My impression was exactly the opposite, that with the change two absents are never equal,
even for `this.equals(this)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message